Extend createiotthings py functionality #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends support for the .json config introduced by `create-update-simplified` and `cleanup-simplified`. This commit also documents this change in `aws_tool.md` and updates the example .json config with 4 new fields. The user-inputted variables are now stored in a dictionary, as this makes it possible to extract the logic for getting these variables (either from the JSON or command line) into a single function to avoid code duplication. This commit also modifies internal storage of application types to use '-' rather than '_' between words. Signed-off-by: Reuben Cartwright <[email protected]>
In `createIoTThings.py` there is a command that takes a .json config and deletes all AWS entities described in there. This commit extends that command to search the credentials directory, and identify AWS Thing certificates before deleting these Things and their possibly related entities (which are generated using the .json config as well). This behaviour only occurs if the `extended` flag is set on the cleanup command. This commit also documents this command in `aws_tool.md`. Signed-off-by: Reuben Cartwright <[email protected]>
urutva
approved these changes
Sep 19, 2024
aggarg
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In createIoTThings.py there is a command that takes a .json config and deletes all AWS entities described in there. This PR extends that command to search the credentials directory, and identify AWS Thing certificates before asking to delete these Things and their possibly related entities (which are generated using the .json config as well). This PR also documents this command in aws_tool.md.
This PR extends support for the .json config introduced by create-update-simplified and cleanup-simplified. This PR also documents this change in aws_tool.md and updates the example .json config with 4 new fields. The user-inputted variables are now stored in a dictionary data type within the Python script, as this makes it possible to extract the logic for getting these variables (either from the JSON or command line) into a single function to avoid code duplication.
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.